contrib/gofiber/fiber.v2: add reference to initial middleware span/context #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text StartSpanFromContext in the middleware was throwing away the returning context which prevents subsequent spans from referencing the original request span. Instead we set fiber's user context as the inital middleware context and reference that in subsequent spans via c.UserContext() Fixes #990
knusbaum
requested changes
Aug 30, 2021
knusbaum
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StartSpanFromContext in the middleware was throwing away the returning context
which prevents subsequent spans from referencing the original request span.
Instead we set fiber's user context as the initial middleware context which allows
users to reference that in subsequent spans via UserContext()
Fixes: #990